[webkit-reviews] review canceled: [Bug 106620] [EFL] Add support for MHTML save/load feature to MiniBrowser : [Attachment 182501] Patch

[bugzilla-daemon at webkit.org]

KwangYong Choi <ky0.choi at samsung.com> has canceled KwangYong Choi
<ky0.choi at samsung.com>'s request for review:
Bug 106620: [EFL] Add support for MHTML save/load feature to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=106620

Attachment 182501: Patch
https://bugs.webkit.org/attachment.cgi?id=182501&action=review

------- Additional Comments from KwangYong Choi <ky0.choi at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182501&action=review


>>>>>> Tools/MiniBrowser/efl/main.c:31
>>>>>> +static const char SAVED_CONTENTS_PATH[] = "/tmp/page.mht";
>>>>> 
>>>>> Can't we show an input popup to get page name ?
>>>> 
>>>> I know, for elementary, it's not simple. I should make popup, layout and
the contents of itself for the simple popup.
>>>> 
>>>> How about keep this simple implementation for the MiniBrowser? This is the
minimal save and load feature of the implementation.
>>> 
>>> If there is no objection from others, I'm ok. But, please support it in
future.
>> 
>> OK.
> 
> It looks it is not difficult to support an input popup dialog.
on_javascript_alert() already implemented a popup dialog based on elementary.
And, it seems to me that you can add input field using elm_entry_add(popup) and
elm_object_context_set(popup, entry).

OK. I will add.

>>> Tools/MiniBrowser/efl/main.c:272
>>> +	 eet_write(ef, "MHTML data", data, strlen(data), 0 /* compress */);
>> 
>> We have used NULL instead of 0 in MiniBrowser.
> 
> The type of the last parameter 'compress' is int. So, I think, 0 is correct
here.
> 
> int eet_write    (Eet_File * ef,
> const char *	   name,
> const void *	   data,
> int	  size,
> int	  compress 
> )

eet_write() writes 'name' also into the file. I may use NULL instead of "MHTML
data".