[webkit-reviews] review granted: [Bug 103952] Scroll gestures should not create wheel events : [Attachment 183069] Patch

Wed Jan 16 17:50:11 PST 2013

James Robinson <jamesr at chromium.org> has granted Terry Anderson
<tdanderson at chromium.org>'s request for review:
Bug 103952: Scroll gestures should not create wheel events
https://bugs.webkit.org/show_bug.cgi?id=103952

Attachment 183069: Patch
https://bugs.webkit.org/attachment.cgi?id=183069&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183069&action=review

OK, R=me.

For folks following along who maybe don't want to dig through the patch, this
patch doesn't introduce any new event types or platform-specific code, it just
fixes the handling of already existing events.

>
LayoutTests/fast/events/touch/gesture/resources/scroll-inside-editable-iframe.h
tml:1
> +<html>

add <!DOCTYPE html> above this (same goes for any other new test files) so the
file is in standards mode, not quirks mode

>
LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html:
1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

just <!DOCTYPE html>

>
LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated
.html:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

just <!DOCTYPE html>

>
LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-editable.html
:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

<!DOCTYPE html>

>
LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.ht
ml:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

<!DOCTYPE html>

>
LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html
:1
> +<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

ditto