[webkit-reviews] review denied: [Bug 107000] [EFL][WK2] Add API unit tests for ewk_pasteboard : [Attachment 182989] patch

Wed Jan 16 17:45:13 PST 2013

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Michal Pakula vel Rutka
<m.pakula at samsung.com>'s request for review:
Bug 107000: [EFL][WK2] Add API unit tests for ewk_pasteboard
https://bugs.webkit.org/show_bug.cgi?id=107000

Attachment 182989: patch
https://bugs.webkit.org/attachment.cgi?id=182989&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182989&action=review

r- because of EFL bot build fail report.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_pasteboard.cpp:88
> +    String pasteboardHTML = ASCIILiteral("<html><body><input type=\"text\"
id=\"test\"></body></html>");

I don't like to use WebKit class in out of WebKit, if possible. Because it
might to make unneeded dependency with WebKit. We have used const char* for a
test html.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_pasteboard.cpp:99
> +    ecore_main_loop_begin();

I wonder why you need to start ecore main loop whenever mouseClick is called.