[webkit-reviews] review granted: [Bug 107057] Replaced specifiers variable with is_debug in builders.py : [Attachment 183046] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 16 16:20:07 PST 2013
Dirk Pranke <dpranke at chromium.org> has granted Timothy Loh
<timloh at chromium.org>'s request for review:
Bug 107057: Replaced specifiers variable with is_debug in builders.py
https://bugs.webkit.org/show_bug.cgi?id=107057
Attachment 183046: Patch
https://bugs.webkit.org/attachment.cgi?id=183046&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
This generally seems like an improvement. I have long suspect that the
specifiers list was underused.
One note, though: if the only bot we have for a port is a debug bot,
builder_name_for_port_name() won't be correct. Of course, it already wasn't
correct.
More information about the webkit-reviews
mailing list