[webkit-reviews] review denied: [Bug 107056] Fix mac build system warnings introduced by r139866 : [Attachment 183049] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 16 16:08:56 PST 2013
Benjamin Poulain <benjamin at webkit.org> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 107056: Fix mac build system warnings introduced by r139866
https://bugs.webkit.org/show_bug.cgi?id=107056
Attachment 183049: Patch
https://bugs.webkit.org/attachment.cgi?id=183049&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183049&action=review
> Source/WebCore/WebCore.exp.in:1580
> .objc_class_name_DOMCSSStyleSheet
> -.objc_class_name_DOMCSSSupportsRule
> .objc_class_name_DOMCSSUnknownRule
> .objc_class_name_DOMCSSValue
This is incorrect. I landed something for this:
http://trac.webkit.org/changeset/139933
> Source/WebCore/WebCore.xcodeproj/project.pbxproj:26129
> + FC54D05716A7673100575E4D /* CSSSupportsRule.h
in Headers */,
> + FC54D05816A7676E00575E4D /* JSCSSSupportsRule.h
in Headers */,
This build section should be sorted alphabetically.
More information about the webkit-reviews
mailing list