[webkit-reviews] review granted: [Bug 86706] Parsing of :nth-* pseudo-classes should accept strings starting with "+n" : [Attachment 142425] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 16 15:11:51 PST 2013


Darin Adler <darin at apple.com> has granted Kang-Hao (Kenny) Lu
<kennyluck at csail.mit.edu>'s request for review:
Bug 86706: Parsing of :nth-* pseudo-classes should accept strings starting with
"+n"
https://bugs.webkit.org/show_bug.cgi?id=86706

Attachment 142425: proposed patch
https://bugs.webkit.org/attachment.cgi?id=142425&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=142425&action=review


> LayoutTests/fast/css/nth-child-unary-prefix.html:4
>      <title>CSS Test: :nth-child selector with unary prefix on step</title>

Really lame that this test writes nothing to reflect the tests it does; just
says “Pass”. That’s not our best practice for regression tests.


More information about the webkit-reviews mailing list