[webkit-reviews] review granted: [Bug 106931] Table layout does not need to explicitly call computePreferredLogicalWidths : [Attachment 182816] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Ojan Vafai
<ojan at chromium.org>'s request for review:
Bug 106931: Table layout does not need to explicitly call
computePreferredLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=106931

Attachment 182816: Patch
https://bugs.webkit.org/attachment.cgi?id=182816&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182816&action=review


> Source/WebCore/ChangeLog:28
> +	   * rendering/RenderTableCol.cpp:
> +	   (WebCore::RenderTableCol::clearPreferredLogicalWidthsDirtyBits):
> +	   * rendering/RenderTableCol.h:

We should probably explain why this code is needed: columns (col) don't have
the concept of preferred logical width but they rely on propagating the
preferred logical widths bit up to the containing table if their style change.