[webkit-reviews] review denied: [Bug 106871] Update GraphicsContext to support winding rule in clip operator for Core Graphics : [Attachment 183024] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Rik Cabanier <cabanier at adobe.com>'s
request for review:
Bug 106871: Update GraphicsContext to support winding rule in clip operator for
Core Graphics
https://bugs.webkit.org/show_bug.cgi?id=106871

Attachment 183024: Patch
https://bugs.webkit.org/attachment.cgi?id=183024&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183024&action=review


Looks like you are going to go the wrong way. We already have clipPath which
should do what you want. And I am not really a friend of leaving the other
ports behind when it would be fairly easy to implement there as well. However,
this bug should be mainly invalid.

> Source/WebCore/ChangeLog:5
> +

Can you please summarize your changes and what they are good for here please?

> Source/WebCore/ChangeLog:11
> +	   * platform/graphics/GraphicsContext.h: Change canvasClip and clip
signature with default winding rule

End sentences please.

> Source/WebCore/ChangeLog:12
> +	   * platform/graphics/cairo/GraphicsContextCairo.cpp: Update interface
with new signature so it still compiles

Ditto.... And in a couple of other lines as well.