[webkit-reviews] review granted: [Bug 98089] Missing sys/mman.h include on Mac : [Attachment 166567] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Jonathan Liu <net147 at gmail.com>'s
request for review:
Bug 98089: Missing sys/mman.h include on Mac
https://bugs.webkit.org/show_bug.cgi?id=98089

Attachment 166567: Patch
https://bugs.webkit.org/attachment.cgi?id=166567&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Eventually we’ll have to figure out a policy for Mac includes. Generally
speaking the Mac port works by including certain global includes as part of the
prefix, and patches like this are only needed because some other ports are
leaving things out of the global prefix. But since we have a "config.h" that is
used on all platforms, these could instead be fixed by adding more to the
"config.h" or something it includes on those ports. Instead of constantly
taking small patches like this one.

But I’ll set that aside for now and say r=me