[webkit-reviews] review denied: [Bug 87054] ContainerNode::setActive should not sleep for 100ms on platforms that do not implement synchronous repaint(true) semantics : [Attachment 143117] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied James Robinson <jamesr at chromium.org>'s
request for review:
Bug 87054: ContainerNode::setActive should not sleep for 100ms on platforms
that do not implement synchronous repaint(true) semantics
https://bugs.webkit.org/show_bug.cgi?id=87054

Attachment 143117: Patch
https://bugs.webkit.org/attachment.cgi?id=143117&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It seems to me you are saying that nobody except Apple on the Mac wants this
feature of blinking visibly when someone does a programmatic click of a button.
What we want to do is to express two different things at either compile time or
runtime:

1) Do we want this feature at all?
2) Do we have the repaint(true) code implemented needed to implement the
feature?

If either (1) or (2) is false, then we don’t want to do any of the logic and we
certainly don’t want a gratuitous sleep.

What simplifies the situation, though, is that as far as I can tell, we have no
platforms where (1) and (2) are true. Specifically, the WebKit client on Mac
that wanted this was Safari, and Safari has been using WebKit2 and so not
getting this feature for multiple years.

Thus, I think we should delete the code entirely rather than wrapping it this
#if/FIXME mess.

If we were keeping it, I think we should do a better job of teasing out (1) and
(2) rather than conflating them.

Alexey was arguing to keep the code, but I think that currently it’s doing more
harm than good.

By the way, I think that everyone should want this feature on all platforms.
It’s great to see the button pushed!

review- but I will review+ a patch to just remove this entirely