[webkit-reviews] review granted: [Bug 106847] Stub out WebSpeech synthesis : [Attachment 183022] patch fixing style warnings

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 106847: Stub out WebSpeech synthesis
https://bugs.webkit.org/show_bug.cgi?id=106847

Attachment 183022: patch fixing style warnings
https://bugs.webkit.org/attachment.cgi?id=183022&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=183022&action=review


Thanks for updating the patch.	This looks much better!

> Source/WebCore/Modules/speech/SpeechSynthesis.h:55
> +    Vector<RefPtr<SpeechSynthesisVoice> > getVoices() { return m_voiceList;
};

Here you probably want an const Vector<RefPtr<SpeechSynthesisVoice> >& to avoid
making an extra copy of the vector.