[webkit-reviews] review denied: [Bug 106979] [EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL : [Attachment 182935] Fixed patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jaehun Lim
<ljaehun.lim at samsung.com>'s request for review:
Bug 106979: [EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL
https://bugs.webkit.org/show_bug.cgi?id=106979

Attachment 182935: Fixed patch
https://bugs.webkit.org/attachment.cgi?id=182935&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182935&action=review


I am confused. You reorder the functions of PagreUIClient but it does not
really match the order of WKPageUIClient (createNewPage for example).
You ordered PageUIClientEfl.h (which is nice) but the implementaion of
PageUIClientEfl::PageUIClientEfl keeps the old order.

Please make a separate patch to clean EFL PageUIClient, we land that first, and
then we do the implementation for runBeforeUnloadConfirmPanel.

> Source/WebKit2/ChangeLog:11
> +
> +	   Implement runBeforeUnloadConfirmPanel() to support
window.onbeforeunload.
> +	   And adjsust the ordering of functions to kepp in sync with
PageUIClient.
> +
> +	   * UIProcess/efl/PageUIClientEfl.cpp:

Your patch now also sort the callbacks of PageUIClient correctly. You should
have mentioned that in your ChangeLog.