[webkit-reviews] review granted: [Bug 100026] inconsistency in drawImage with target rect negative dimensions. : [Attachment 182865] same patch except s/imgBuffer/imageBuffer/ and s/imgBuffer2/imageBuffer2/

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted arno. <arno at renevier.net>'s request
for review:
Bug 100026: inconsistency in drawImage with target rect negative dimensions.
https://bugs.webkit.org/show_bug.cgi?id=100026

Attachment 182865: same patch except s/imgBuffer/imageBuffer/ and
s/imgBuffer2/imageBuffer2/
https://bugs.webkit.org/attachment.cgi?id=182865&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182865&action=review


Setting to r+ cq+ since Darin already gave r+. I checked that his requested
changes were made.

> PerformanceTests/Canvas/drawimage.html:9
> +var source = document.createElement("canvas");
> +source.width = 300;
> +source.height = 150;

For future reference, these are the default values and thus not necessary.

> PerformanceTests/Canvas/drawimage.html:15
> +var target = document.createElement("canvas");
> +target.width = source.width;
> +target.height = source.height;

Same.