[webkit-reviews] review denied: [Bug 84684] child documents do not immediately clear their rendering trees when parent iframes are set to display: none : [Attachment 138523] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 84684: child documents do not immediately clear their rendering trees when
parent iframes are set to display: none
https://bugs.webkit.org/show_bug.cgi?id=84684

Attachment 138523: Patch
https://bugs.webkit.org/attachment.cgi?id=138523&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=138523&action=review


This seems good, but I’m going to say review- because both the test and the
code change are not quite right yet, in my opinion.

> Source/WebCore/rendering/RenderWidget.cpp:123
> +    // If the widget is a child FrameView and has been destroyed
> +    // clear the child's render tree now, even though references
> +    // to this widget may live on for a bit.

Nothing in this comment makes it clear that this is needed for correctness.