[webkit-reviews] review granted: [Bug 106943] Cues not rendered when they should be : [Attachment 182934] Updated test result

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Victor Carbune
<victor at rosedu.org>'s request for review:
Bug 106943: Cues not rendered when they should be
https://bugs.webkit.org/show_bug.cgi?id=106943

Attachment 182934: Updated test result
https://bugs.webkit.org/attachment.cgi?id=182934&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182934&action=review


I really like the new test - it is concise, thorough, and easy to understand.
Good fix, thanks!

> LayoutTests/media/track/track-cue-rendering-mode-changed.html:12
> +	   var testTrackEnglish, testTrackArabic;

Nit: each variable should be declared independently.

> LayoutTests/media/track/track-cue-rendering-mode-changed.html:15
> +	   function addTracks() {

Nit: a function's opening brace should be on a new line.

> LayoutTests/media/track/track-cue-rendering-mode-changed.html:16
> +	       findMediaElement();

Nit: this should not be necessary, it was call in loaded().