[webkit-reviews] review granted: [Bug 106956] RenderListMarker::computePreferredLogicalWidth should not be public : [Attachment 182893] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 106956: RenderListMarker::computePreferredLogicalWidth should not be public
https://bugs.webkit.org/show_bug.cgi?id=106956

Attachment 182893: Patch
https://bugs.webkit.org/attachment.cgi?id=182893&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182893&action=review


> Source/WebCore/rendering/RenderListMarker.cpp:1365
> +    // FIXME: This if-statement is just a performance optimization, but it's
messy to use the preferredLogicalWidths dirty bit for this.
> +    // It's unclear if this is a premature optimization.
> +    if (!preferredLogicalWidthsDirty())
> +	   return;

It seems like it would be possible for preferredLogicalWidthsDirty to be false
and the content changed, but I guess that means we would have a bug where
changing the content didn't set preferredLogicalWidthsDirty to true?