[webkit-reviews] review denied: [Bug 107021] Web Inspector: Introduce FileSystemWorkspaceProvider to allow showing files from file system in workspace. : [Attachment 182994] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 16 09:26:16 PST 2013


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 107021: Web Inspector: Introduce FileSystemWorkspaceProvider to allow
showing files from file system in workspace.
https://bugs.webkit.org/show_bug.cgi?id=107021

Attachment 182994: Patch
https://bugs.webkit.org/attachment.cgi?id=182994&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182994&action=review


Looks good.

> Source/WebCore/inspector/front-end/FileSystemMapping.js:96
> +    Object.call(this);

WebInspector.

> Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:2
> + * Copyright (C) 2012 Google Inc. All rights reserved.

2013

> Source/WebCore/inspector/front-end/FileSystemWorkspaceProvider.js:426
> +    function toArray(list) {

{!


More information about the webkit-reviews mailing list