[webkit-reviews] review denied: [Bug 105523] Web Inspector: highlight occurences of word in DefaultTextEditor : [Attachment 182979] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 16 08:48:48 PST 2013
Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 105523: Web Inspector: highlight occurences of word in DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=105523
Attachment 182979: Patch
https://bugs.webkit.org/attachment.cgi?id=182979&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182979&action=review
> Source/WebCore/inspector/front-end/DefaultTextEditor.js:3043
> + if (!range) {
if (!this._muteSelectionListener)
> Source/WebCore/inspector/front-end/DefaultTextEditor.js:3055
> + if (selectedText == this._selectedWord)
===
> Source/WebCore/inspector/front-end/DefaultTextEditor.js:3077
> + this._mainPanel.highlightRegex(this._activeRegex,
"text-editor-token-highlight")
this._muteSelectionListener = true;
this._mainPanel.highlightRegex(this._activeRegex,
"text-editor-token-highlight");
delete this._muteSelectionListener;
More information about the webkit-reviews
mailing list