[webkit-reviews] review granted: [Bug 106983] INPUT_MULTIPLE_FIELDS_UI: Unable to edit a time field with step=86400, and confusing appearance : [Attachment 182928] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted  review:
Bug 106983: INPUT_MULTIPLE_FIELDS_UI: Unable to edit a time field with
step=86400, and confusing appearance
https://bugs.webkit.org/show_bug.cgi?id=106983

Attachment 182928: Patch
https://bugs.webkit.org/attachment.cgi?id=182928&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182928&action=review


Looks good to me.

>>> Source/WebCore/ChangeLog:14
>>> +	     - We don't make hour fields read-only for input[type=time].
>> 
>> Shall we add a test case for input[type=time] too? BTW, what about
input[type=datetime]?
> 
> Yes, I already added tests for input[type=time] and added a reason of no
input[type=datetime] tests to LayoutTests/ChangeLog.

Sorry, I missed that.