[webkit-reviews] review canceled: [Bug 106983] INPUT_MULTIPLE_FIELDS_UI: Unable to edit a time field with step=86400, and confusing appearance : [Attachment 182928] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has canceled Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 106983: INPUT_MULTIPLE_FIELDS_UI: Unable to edit a time field with
step=86400, and confusing appearance
https://bugs.webkit.org/show_bug.cgi?id=106983

Attachment 182928: Patch
https://bugs.webkit.org/attachment.cgi?id=182928&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182928&action=review


>> Source/WebCore/ChangeLog:14
>> +	    - We don't make hour fields read-only for input[type=time].
> 
> Shall we add a test case for input[type=time] too? BTW, what about
input[type=datetime]?

Yes, I already added tests for input[type=time] and added a reason of no
input[type=datetime] tests to LayoutTests/ChangeLog.

>> Source/WebCore/ChangeLog:36
>> +	    and month fields explicitly here because a day field can be
read-only
> 
> Shall we add an ASSERT() to check this?

will do.