[webkit-reviews] review denied: [Bug 106897] Web Inspector: array grouping does not work big sparse arrays : [Attachment 182787] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 106897: Web Inspector: array grouping does not work big sparse arrays
https://bugs.webkit.org/show_bug.cgi?id=106897

Attachment 182787: Patch
https://bugs.webkit.org/attachment.cgi?id=182787&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182787&action=review


> Source/WebCore/ChangeLog:8
> +	   Now we will choose between array index iteration and object
properties iteration for sparse arrays.

It is not clear from the test case how this helps.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:651
> +	       if (toIndex - fromIndex < 250000) {

Magic number

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:749
> +	       var ownPropertyNames = Object.getOwnPropertyNames(this);

Looks like a lot of copypaste.