[webkit-reviews] review denied: [Bug 106979] [EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL : [Attachment 182921] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jaehun Lim
<ljaehun.lim at samsung.com>'s request for review:
Bug 106979: [EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL
https://bugs.webkit.org/show_bug.cgi?id=106979

Attachment 182921: Patch
https://bugs.webkit.org/attachment.cgi?id=182921&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182921&action=review


> Source/WebKit2/ChangeLog:3
> +	   [EFL][WK2] Add support for onBeforeUnload handling

This title is confusing. Please update it.

> Source/WebKit2/ChangeLog:12
> +	   (WebKit):

You can remove this, it is likely generated from the namespace.

> Source/WebKit2/UIProcess/efl/PageUIClientEfl.cpp:231
>  
> +    uiClient.runBeforeUnloadConfirmPanel = runBeforeUnloadConfirmPanel;
> +

For clarity, you should keep those in the order of the PageUIClient.

> Source/WebKit2/UIProcess/efl/PageUIClientEfl.h:74
> +    static bool runBeforeUnloadConfirmPanel(WKPageRef, WKStringRef,
WKFrameRef, const void*);

ditto.