[webkit-reviews] review denied: [Bug 105787] [Texmap] Refactor code related to debug border and repaint count. : [Attachment 182903] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 105787: [Texmap] Refactor code related to debug border and repaint count.
https://bugs.webkit.org/show_bug.cgi?id=105787

Attachment 182903: Patch
https://bugs.webkit.org/attachment.cgi?id=182903&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182903&action=review


Getting there :)

> Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp:147
> +    TransformationMatrix adjustedTransform = transform;
> +    adjustedTransform.multiply(TransformationMatrix::rectToRect(rect(),
targetRect));

This needs to move to its own helper function.

> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:143
> +	   // Draw the repaint count of only a backing store.

// Only draw repaint count for the main backing store.

> Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:162
> +    FloatRect rectOnContents(FloatPoint::zero(), m_size);
> +    TransformationMatrix adjustedTransform = transform;
> +   
adjustedTransform.multiply(TransformationMatrix::rectToRect(rectOnContents,
targetRect));

This needs to move to a helper function; Probably in TextureMapperBackingStore.


>
Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
245
> +void CoordinatedLayerTreeHostProxy::setRepaintCount(CoordinatedLayerID id,
int value)

setLayerRepaintCount