[webkit-reviews] review granted: [Bug 106844] sheriff-bot should reply to all messages immediately, even if busy : [Attachment 182902] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 21:58:17 PST 2013


Eric Seidel <eric at webkit.org> has granted Alan Cutter
<alancutter at chromium.org>'s request for review:
Bug 106844: sheriff-bot should reply to all messages immediately, even if busy
https://bugs.webkit.org/show_bug.cgi?id=106844

Attachment 182902: Patch
https://bugs.webkit.org/attachment.cgi?id=182902&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182902&action=review


This seems OK.	More what I meant by this bug was the SB should ack any message
it recieves, even if it's busy with another command.  This doesn't really do
that, as far as I can tell.

> Tools/Scripts/webkitpy/common/thread/messagepump.py:42
> -    interval = 10 # seconds
> +    interval = 1  # seconds

Do we know why it was 10s before?


More information about the webkit-reviews mailing list