[webkit-reviews] review denied: [Bug 105902] Prevent ScrollView::updateScrollbars() from creating scrollbars with negative sizes : [Attachment 181794] Patch

Tue Jan 15 19:54:51 PST 2013

James Robinson <jamesr at chromium.org> has denied Steve Block
<steveblock at chromium.org>'s request for review:
Bug 105902: Prevent ScrollView::updateScrollbars() from creating scrollbars
with negative sizes
https://bugs.webkit.org/show_bug.cgi?id=105902

Attachment 181794: Patch
https://bugs.webkit.org/attachment.cgi?id=181794&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181794&action=review

> Source/WebCore/ChangeLog:8
> +	   No change in behaviour, covered by existing tests.

are you saying this test case:

<!DOCTYPE html>
<div style="overflow:scroll; width:6px; height:30px">x

and this one:

<!DOCTYPE html>
<body dir="rtl">
<div style="overflow:scroll; width:6px; height:30px">x

render the same with and without this patch?  I really doubt that's the case
and the behavior (even if it is unchanged) needs to be covered by layout tests.