[webkit-reviews] review denied: [Bug 106968] Move image alpha decoding decisions into Image::currentFrameHasAlpha : [Attachment 182892] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 19:45:21 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Philip Rogers
<pdr at google.com>'s request for review:
Bug 106968: Move image alpha decoding decisions into
Image::currentFrameHasAlpha
https://bugs.webkit.org/show_bug.cgi?id=106968

Attachment 182892: Patch
https://bugs.webkit.org/attachment.cgi?id=182892&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I don't like how this pushes complexity onto the caller. How does the caller
know if it's OK to decode? What's the impact of passing DoNotForceDecode when a
decode is actually needed: is the answer possibly wrong?


More information about the webkit-reviews mailing list