[webkit-reviews] review granted: [Bug 103635] [chromium] Create GraphicsLayerChromiums using a factory : [Attachment 181304] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted vollick at chromium.org's request
for review:
Bug 103635: [chromium] Create GraphicsLayerChromiums using a factory
https://bugs.webkit.org/show_bug.cgi?id=103635

Attachment 181304: Patch
https://bugs.webkit.org/attachment.cgi?id=181304&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=181304&action=review


Still r=me but still needs some cleanup

> Source/WebKit/chromium/src/NonCompositedContentHost.cpp:36
> +#include "Chrome.h"
>  #include "FloatPoint.h"
>  #include "FloatRect.h"
>  #include "GraphicsLayer.h"
>  #include "GraphicsLayerChromium.h"
> +#include "GraphicsLayerFactory.h"
> +#include "Page.h"

please trim includes - i don't think you need any of these new includes, just a
forward declaration of WebCore::GraphicsLayerFactory somewhere

> Source/WebKit/chromium/src/NonCompositedContentHost.h:68
> +    explicit NonCompositedContentHost(WebViewImpl*,
WebCore::GraphicsLayerFactory*);

no explicit for 2-argument constructors

> Source/WebKit/chromium/src/PageOverlay.cpp:32
> +#include "Chrome.h"

trim unnecessary include

> Source/WebKit/chromium/src/WebViewImpl.cpp:4035
> +	   m_nonCompositedContentHost = NonCompositedContentHost::create(this,
m_chromeClientImpl.graphicsLayerFactory());

since you've added the WebViewImpl::graphicsLayerFactory() getter, i'd use that
here as well