[webkit-reviews] review granted: [Bug 106961] Add the ability for a RenderLayerBacking to have a layer that renders backgrounds. : [Attachment 182885] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 106961: Add the ability for a RenderLayerBacking to have a layer that
renders backgrounds.
https://bugs.webkit.org/show_bug.cgi?id=106961

Attachment 182885: Patch
https://bugs.webkit.org/attachment.cgi?id=182885&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182885&action=review


> Source/WebCore/ChangeLog:8
> +	   In some cases we need a compositing layer to renders its background
into

missing words near "to renders"

> Source/WebCore/rendering/RenderLayerBacking.cpp:759
> +	   FloatSize backgroundSize = contentsSize;
> +	   IntSize backgroundOffset = m_graphicsLayer->offsetFromRenderer();
> +	   m_backgroundLayer->setPosition(FloatPoint());
> +	   if (backgroundSize != m_backgroundLayer->size()) {
> +	       m_backgroundLayer->setSize(backgroundSize);

Why do you need the local variable backgroundSize?