[webkit-reviews] review granted: [Bug 106601] Clamp TileCache visibleRect to WKView's visibleRect : [Attachment 182880] patch after talking to smfr

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 106601: Clamp TileCache visibleRect to WKView's visibleRect
https://bugs.webkit.org/show_bug.cgi?id=106601

Attachment 182880: patch after talking to smfr
https://bugs.webkit.org/attachment.cgi?id=182880&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182880&action=review


> Source/WebCore/platform/graphics/ca/mac/TileCache.h:173
> +    IntRect m_exposedRect;

A comment to say what this is would be nice.

> Source/WebCore/platform/graphics/ca/mac/TileCache.mm:418
> +    IntRect intersectedVisibleRect = m_visibleRect;

I think it would be fine to call this visibleRect.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:213
> +    BOOL _expandsToFitContent;

Maybe this should contain 'autoLayout' in the words.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:3100
> +    _data->_page->setMinimumLayoutWidth(expandsToFit ? minimumLayoutWidth :
0);

Isn't this the same as _data->_page->setMinimumLayoutWidth(minimumLayoutWidth);
?

> Source/WebKit2/WebProcess/WebPage/WebPage.h:607
> +    bool mainFrameIsScrollable() { return m_mainFrameIsScrollable; }

const

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:347
> +    m_exposedRect = exposedRect;
> +    mainFrameTiledBacking()->setExposedRect(exposedRect);

Shouldn't this map through the scroll offset?