[webkit-reviews] review granted: [Bug 95793] Improve the initialization of empty strings : [Attachment 162154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 16:49:30 PST 2013


Eric Seidel <eric at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 95793: Improve the initialization of empty strings
https://bugs.webkit.org/show_bug.cgi?id=95793

Attachment 162154: Patch
https://bugs.webkit.org/attachment.cgi?id=162154&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It's difficult for me to believe that these will be used consistently
correctly.  But overall this patch looks like a good thing.  I think I'd prefer
if we just had emptyString() which returns a ref, but if you believe this to be
a real perf/size win, then it's worth it. You should obviously be aware that
your hard-work of tuning is very likely to be stale immediately. :)


More information about the webkit-reviews mailing list