[webkit-reviews] review denied: [Bug 105729] Mouse cursor is not reset when a new page is loaded : [Attachment 180987] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 105729: Mouse cursor is not reset when a new page is loaded
https://bugs.webkit.org/show_bug.cgi?id=105729

Attachment 180987: Patch
https://bugs.webkit.org/attachment.cgi?id=180987&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=180987&action=review


Seems like a good idea to get the cursor set, but we need to do this some way
other than setting it explicitly to the pointer cursor.

> Source/WebCore/loader/FrameLoader.cpp:1813
> +    // Make sure the mouse cursor is reset.
> +    if (isLoadingMainFrame())
> +	   m_frame->page()->chrome()->client()->setCursor(pointerCursor());

This is not right. We want to set the cursor to the appropriate cursor for the
new page, not unconditionally set it to a pointer. We don’t want the cursor to
flash to a pointer every time a new page is loaded, if we’re going from one
page to the next.