[webkit-reviews] review denied: [Bug 104682] Graphics context uses stroke style from previous renderings on Skia/Cairo : [Attachment 178831] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 15:44:41 PST 2013


Darin Adler <darin at apple.com> has denied Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 104682: Graphics context uses stroke style from previous renderings on
Skia/Cairo
https://bugs.webkit.org/show_bug.cgi?id=104682

Attachment 178831: Patch
https://bugs.webkit.org/attachment.cgi?id=178831&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178831&action=review


> Source/WebCore/rendering/InlineTextBox.cpp:969
> +    // FIXME: This fixes a rendering issue in Skia - rect drawing uses
stroke style from previous
> +    // rendering artifact.
> +    context->save();

Doesn’t make sense that this is Skia-specific. It’s the job of the
GraphicsContext class to abstract things like this and make them work the same
across multiple graphics systems. If it works on other platforms and is broken
on Skia, it’s likely a bug in the GraphicsContext implementation, not something
that should require changing this code.

Doing a save/restore every time we paint a decoration on an inline text box
will likely be a measurable performance regression, so we only want to make
that change if we absolutely have to. This bug needs further investigation.


More information about the webkit-reviews mailing list