[webkit-reviews] review granted: [Bug 100026] inconsistency in drawImage with target rect negative dimensions. : [Attachment 179563] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted arno. <arno at renevier.net>'s request
for review:
Bug 100026: inconsistency in drawImage with target rect negative dimensions.
https://bugs.webkit.org/show_bug.cgi?id=100026

Attachment 179563: Patch
https://bugs.webkit.org/attachment.cgi?id=179563&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179563&action=review


> Source/WebCore/platform/graphics/filters/FEComposite.cpp:278
> +    ImageBuffer* imgBuffer = in->asImageBuffer();
> +    ImageBuffer* imgBuffer2 = in2->asImageBuffer();

We normally prefer not to abbreviate words like “image” as “img”. These should
be named imageBuffer and imageBuffer2.