[webkit-reviews] review granted: [Bug 106843] [Sub pixel layout] RTL cells with padding wraps : [Attachment 182661] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 14:58:14 PST 2013


Levi Weintraub <leviw at chromium.org> has granted Emil A Eklund
<eae at chromium.org>'s request for review:
Bug 106843: [Sub pixel layout] RTL cells with padding wraps
https://bugs.webkit.org/show_bug.cgi?id=106843

Attachment 182661: Patch
https://bugs.webkit.org/attachment.cgi?id=182661&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182661&action=review


> Source/WebCore/rendering/RenderTable.h:198
> +    virtual LayoutUnit paddingEnd() const OVERRIDE { return
static_cast<int>(RenderBlock::paddingEnd()); }
> +    virtual LayoutUnit paddingStart() const OVERRIDE { return
static_cast<int>(RenderBlock::paddingStart()); }

Please add a one-liner comment explaining why this is done.


More information about the webkit-reviews mailing list