[webkit-reviews] review granted: [Bug 106834] Add new API for text search in WebKit2 : [Attachment 182817] Patch2

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 106834: Add new API for text search in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=106834

Attachment 182817: Patch2
https://bugs.webkit.org/attachment.cgi?id=182817&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182817&action=review


> Source/WebCore/page/Page.cpp:578
> +    // find all the Ranges for the matching text.
> +    // Upon return, indexForSelection will be one of the following:
> +    // 0 if there is no user selection
> +    // the index of the first range after the user selection
> +    // -1 if there is no matching text after the user selection.

I think this comment is more appropriate for the header. You could use an enum
for the special values.