[webkit-reviews] review granted: [Bug 106916] [V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize() : [Attachment 182792] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 106916: [V8] Make an Isolate parameter mandatory in
SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=106916

Attachment 182792: Patch
https://bugs.webkit.org/attachment.cgi?id=182792&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182792&action=review


> Source/WebCore/bindings/v8/SerializedScriptValue.h:88
> +    ScriptValue deserializeForInspector(ScriptState*);
> +    ScriptValue deserializeForInspector(ScriptState*, v8::Isolate*);

We should put the Isolate into ScriptState instead of passing them separately. 
Everyone who takes a ScriptState is going to need an isolate.