[webkit-reviews] review granted: [Bug 106899] [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal to WebCore/platform : [Attachment 182749] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 15 12:23:54 PST 2013
Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 106899: [Chromium] Move SocketStreamHandle and SocketStreamHandleInternal
to WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=106899
Attachment 182749: Patch
https://bugs.webkit.org/attachment.cgi?id=182749&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182749&action=review
This looks good. All these files have minor style issues, but I think you're
right not to chase them.
> Source/WebCore/platform/network/chromium/SocketStreamHandleInternal.h:42
> +
Usually we skip these blank lines for forward declarations.
> Source/WebCore/platform/network/chromium/SocketStreamHandleInternal.h:46
> +
This one too
More information about the webkit-reviews
mailing list