[webkit-reviews] review granted: [Bug 106913] Upstream iOS changes for ANGLE project : [Attachment 182786] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 106913: Upstream iOS changes for ANGLE project
https://bugs.webkit.org/show_bug.cgi?id=106913

Attachment 182786: Patch
https://bugs.webkit.org/attachment.cgi?id=182786&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182786&action=review


r=me

> Source/ThirdParty/ANGLE/ChangeLog:4
> +	   <http://webkit.org/b/000000>

Nit: Update the bug link before landing

> Source/ThirdParty/ANGLE/ChangeLog:20
> +	   files are sipmly ignored without an error by Xcode.

Typo: sipmly

> Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:14
> +GCC_ENABLE_OBJC_GC_iphonesimulator = NO;

Nit: Normally the _iphonesimulator version just uses the _iphoneos version, so:


    GCC_ENABLE_OBJC_GC_iphonesimulator = $(GCC_ENABLE_OBJC_GC_iphoneos)

Up to you on making this change. That just seems to be the existing convention
but it doesn't seem necessary.