[webkit-reviews] review requested: [Bug 106913] Upstream iOS changes for ANGLE project : [Attachment 182786] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 09:09:22 PST 2013


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 106913: Upstream iOS changes for ANGLE project
https://bugs.webkit.org/show_bug.cgi?id=106913

Attachment 182786: Patch
https://bugs.webkit.org/attachment.cgi?id=182786&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
<http://webkit.org/b/000000>

Reviewed by NOBODY (OOPS!).

* ANGLE.xcodeproj/project.pbxproj:
- Use $(INSTALL_PATH_PREFIX) with CopyFiles build phase paths.
- Add iOS.xcconfig to project.
* Configurations/ANGLE.xcconfig:
- Use INSTALL_PATH_ACTUAL instead of INSTALL_PATH.  (See below.)
- Use $(INSTALL_PATH_PREFIX) with PUBLIC_HEADERS_FOLDER_PATH.
* Configurations/Base.xcconfig:
- Include iOS.xcconfig.
- Add per-platform values for GCC_ENABLE_OBJC_GC and
GCC_MODEL_TUNING.
- Define INSTALL_PATH when building for macosx SDK.
* Configurations/iOS.xcconfig: Add.  Note that missing include
files are sipmly ignored without an error by Xcode.
---
 5 files changed, 39 insertions(+), 6 deletions(-)


More information about the webkit-reviews mailing list