[webkit-reviews] review granted: [Bug 106774] [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel layout : [Attachment 182580] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 08:54:10 PST 2013


Martin Robinson <mrobinson at webkit.org> has granted Dominik Röttsches (drott)
<dominik.rottsches at intel.com>'s request for review:
Bug 106774: [EFL] Update freetype in jhbuild to 2.4.11 and activate subpixel
layout
https://bugs.webkit.org/show_bug.cgi?id=106774

Attachment 182580: Patch
https://bugs.webkit.org/attachment.cgi?id=182580&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182580&action=review


Looks good, but a couple small comments...

> Source/WTF/ChangeLog:8
> +	   Let's update FreeType accordinggly, but bump it to 2.4.11 due to the


Spelling nit: accordingly

>> Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp:69
>> +#if ENABLE(SUBPIXEL_LAYOUT)
>> +	m_fontMetrics.setLineSpacing(ascent + descent + lineGap);
> 
> Updated patch with removing rounding, as discussed in
https://bugs.webkit.org/show_bug.cgi?id=102374#c20 and following.

I understand why you are doing this here, but from what I understand
SUBPIXEL_LAYOUT isn't really accurate here. It would be more accurate to say
PLATFORM(EFL) since this fix is independent of subpixel layout. Or am I
misunderstanding this?


More information about the webkit-reviews mailing list