[webkit-reviews] review denied: [Bug 105523] Web Inspector: highlight occurences of word in DefaultTextEditor : [Attachment 182761] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 105523: Web Inspector: highlight occurences of word in DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=105523

Attachment 182761: Patch
https://bugs.webkit.org/attachment.cgi?id=182761&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182761&action=review


> Source/WebCore/inspector/front-end/DefaultTextEditor.js:3046
> +	       return this._deselect();

Although I would love to act alike, we don't do that.

> Source/WebCore/inspector/front-end/DefaultTextEditor.js:3068
> +    _select: function(selectedWord)

this naming is misleading - it does not mutate selection.