[webkit-reviews] review denied: [Bug 106895] [chromium] move setMockDeviceOrientation to TestRunner library : [Attachment 182745] Patch

[bugzilla-daemon at webkit.org]

jochen at chromium.org has denied Dan Carney <dcarney at google.com>'s request for
review:
Bug 106895: [chromium] move setMockDeviceOrientation to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106895

Attachment 182745: Patch
https://bugs.webkit.org/attachment.cgi?id=182745&action=review

------- Additional Comments from jochen at chromium.org
View in context: https://bugs.webkit.org/attachment.cgi?id=182745&action=review


> Tools/DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:89
> +    virtual WebKit::WebDeviceOrientationClientMock*
deviceOrientationClientMock() { return 0; }

content_shell doesn't have a mock, but a real client. I think instead of adding
the mock to the delegate interface, we should add a setDeviceOrientation()
callback.