[webkit-reviews] review granted: [Bug 106371] Web Inspector: Allow Page.navigate to open file:// urls : [Attachment 182736] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 106371: Web Inspector: Allow Page.navigate to open file:// urls
https://bugs.webkit.org/show_bug.cgi?id=106371

Attachment 182736: Patch
https://bugs.webkit.org/attachment.cgi?id=182736&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182736&action=review


> Source/WebCore/ChangeLog:8
> +	   Provided a way for embedder to handle Page.navigate.

Please describe here why we cannot use changeLocation on the main frame loader
and need this method.

> Source/WebKit/chromium/src/InspectorClientImpl.h:67
> +    virtual bool canClearBrowserCookies() { return true; }

What's the purpose of moving this out of the .cpp file?