[webkit-reviews] review granted: [Bug 106533] [Refactoring] HTMLTextFormControlElement should use shadowHost instead of shadowAncestorNode : [Attachment 182076] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 106533: [Refactoring] HTMLTextFormControlElement should use shadowHost
instead of shadowAncestorNode
https://bugs.webkit.org/show_bug.cgi?id=106533

Attachment 182076: Patch
https://bugs.webkit.org/attachment.cgi?id=182076&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182076&action=review


ok

> Source/WebCore/html/HTMLTextFormControlElement.cpp:647
> +    return ancestor ? toTextFormControl(ancestor) : 0;

Not your fault, but this code looks dangerous.	Who ensures that the position
points shadow nodes in text input or textarea?