[webkit-reviews] review granted: [Bug 106640] Web Inspector: [Canvas] introduce CallArgument type into the protocol : [Attachment 182311] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 15 01:15:20 PST 2013


Yury Semikhatsky <yurys at chromium.org> has granted Andrey Adaikin
<aandrey at chromium.org>'s request for review:
Bug 106640: Web Inspector: [Canvas] introduce CallArgument type into the
protocol
https://bugs.webkit.org/show_bug.cgi?id=106640

Attachment 182311: Patch
https://bugs.webkit.org/attachment.cgi?id=182311&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182311&action=review


The patch mixes several unrelated changes which can be done in a separate CLs
and would simplify the review process.

> Source/WebCore/inspector/Inspector.json:3210
> +		       { "name": "arguments", "type": "array", "items": {
"$ref": "CallArgument" }, "optional": true },

Would be nice to have descriptions for the properties.


More information about the webkit-reviews mailing list