[webkit-reviews] review denied: [Bug 106874] LongPress should start drag&drop draggable elements in iframes : [Attachment 182707] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied yongsheng
<yongsheng.zhu at intel.com>'s request for review:
Bug 106874: LongPress should start drag&drop draggable elements in iframes
https://bugs.webkit.org/show_bug.cgi?id=106874

Attachment 182707: Patch
https://bugs.webkit.org/attachment.cgi?id=182707&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
> thanks, you're right. If different platforms have different behaviors, i'd
like to define a function sth like PassLongPressEventToSubFrame, so that qt,
chromium, gtk and others can have their own implementations. 
> what do you think?

It depends a bit if a behavior depends on the platform and/or the port.

For example if Linux/Windows have a particular behavior that should be true for
all ports, a PlatformStragegy could be a better solution.

If the behavior is per port, simply using #ifdef is ok.

First, ask the other ports (possibly on webkit-dev). Once you know the kind of
abstraction you need, you can make design decisions for EventHandler.

I r- this for now. Let's get some feedback first on what people want.