[webkit-reviews] review granted: [Bug 106854] Generalize DocumentWeakReference into WTF::WeakPtr : [Attachment 182679] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 106854: Generalize DocumentWeakReference into WTF::WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=106854

Attachment 182679: Patch
https://bugs.webkit.org/attachment.cgi?id=182679&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182679&action=review


Looks reasonable to me.  You should probably wait for others to wake and
comment since we're adding something to WTF and thus might want a bit broader
consensus. :)

> Source/WebCore/dom/Document.cpp:4786
> -    RefPtr<DocumentWeakReference> documentReference;
> +    WeakPtr<Document> documentRef;

I'm not sure why you changed the variable name.