[webkit-reviews] review denied: [Bug 106830] Use MADV_FREE_REUSABLE to return JIT memory to OS : [Attachment 182632] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Pratik Solanki
<psolanki at apple.com>'s request for review:
Bug 106830: Use MADV_FREE_REUSABLE to return JIT memory to OS
https://bugs.webkit.org/show_bug.cgi?id=106830

Attachment 182632: Patch
https://bugs.webkit.org/attachment.cgi?id=182632&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Thanks for tackling this.

This patch has a bug: notifyNeedPage() forgets to MADV_FREE_REUSE.

Let me suggest another approach, which also fixes the bug:

(a) Make a USE(MADV_FREE_FOR_JIT_MEMORY) Platform.h #define, with a comment
about MADV_FREE_REUSABLE not working on older OS's.
(b) Set that to true on older OS's
(c) Change "#if OS(DARWIN)" to "#if USE(MADV_FREE_FOR_JIT_MEMORY)" in this
file.