[webkit-reviews] review granted: [Bug 104198] webkitpy's clean_working_directory has a confusing name : [Attachment 182673] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tim 'mithro' Ansell
<mithro at mithis.com>'s request for review:
Bug 104198: webkitpy's clean_working_directory has a confusing name
https://bugs.webkit.org/show_bug.cgi?id=104198

Attachment 182673: Patch
https://bugs.webkit.org/attachment.cgi?id=182673&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=182673&action=review


Looks good.

> Tools/Scripts/webkitpy/common/checkout/scm/git.py:53
> +	   Exception.__init__(self, "Found %s local commits and the working
directory is %s" % (
> +	       num_local_commits, ["clean", "not
clean"][has_working_directory_changes]))

I think this part landed in a separate patch.