[webkit-reviews] review denied: [Bug 105574] Fix scrollRectToVisible in the presence of transforms : [Attachment 182672] Now with test results.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Hopman
<cjhopman at chromium.org>'s request for review:
Bug 105574: Fix scrollRectToVisible in the presence of transforms
https://bugs.webkit.org/show_bug.cgi?id=105574

Attachment 182672: Now with test results.
https://bugs.webkit.org/attachment.cgi?id=182672&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=182672&action=review


Code changes are OK, but I think the tests could be improved.

> LayoutTests/ChangeLog:17
> +	   *
platform/chromium-linux/editing/input/reveal-caret-of-transformed-input-scrolla
ble-parent-expected.png: Added.
> +	   *
platform/chromium-linux/editing/input/reveal-caret-of-transformed-input-scrolla
ble-parent-expected.txt: Added.
> +	   *
platform/chromium-linux/editing/input/reveal-caret-of-transformed-multiline-inp
ut-expected.png: Added.
> +	   *
platform/chromium-linux/editing/input/reveal-caret-of-transformed-multiline-inp
ut-expected.txt: Added.

Can you make these ref tests, or fix them to use less text so that the results
are more useful between platforms? Also, why do the expected images not use the
mock scrollbar theme? Most platforms use that now.